[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: arm64: Adding VFP save/restore support.

On Thu, 2014-02-06 at 12:44 +0000, Julien Grall wrote:
> > +                 :: "r" ((char *)(&v->arch.vfp.fpregs)): "memory");
> I remember we had a discussion when I have implemented vfp context 
> switch for arm32 for the memory constraints 
> (http://lists.xen.org/archives/html/xen-devel/2013-06/msg00110.html).
> I think you should use "=Q" also here to avoid cloberring the whole memory.

Yes, I forgot to say: I think getting something in now is the priority,
which is why I committed it, but this should be tightened up, probably
for 4.5 unless the difference is benchmarkable.

> At the same time, is it necessary the (char *)?

I missed that, yes I suspect it is unnecessary.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.