[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3 V3] mcheck, vmce: Allow vmce_amd_* functions to handle AMD thresolding MSRs

>>> On 05.02.14 at 21:28, Aravind Gopalakrishnan 
>>> <aravind.gopalakrishnan@xxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/mcheck/vmce.h
> +++ b/xen/arch/x86/cpu/mcheck/vmce.h
> @@ -8,6 +8,9 @@ int vmce_init(struct cpuinfo_x86 *c);
>  #define dom0_vmce_enabled() (dom0 && dom0->max_vcpus && dom0->vcpu[0] \
>          && guest_enabled_event(dom0->vcpu[0], VIRQ_MCA))
> +#define AMD_MC4_MISC1_INCLUDE_MASK          0x13

As said before, this ought to remain 3, and has nothing to do
with AMD. No need to have a variable for this at all.

> +#define AMD_MC4_EXTENDED_MISC_INCLUDE_MASK  0xc0000000

For this one I meanwhile think that the better mask would be
-MSR_IA32_MC0_CTL (i.e. 0xfffffc00). Which then would also
eliminate the need for a separate manifest constant.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.