Re: [Xen-devel] [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.02.14 at 17:03, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> --- a/tools/libxc/xc_domain.c
> +++ b/tools/libxc/xc_domain.c
> @@ -48,6 +48,16 @@ int xc_domain_create(xc_interface *xch,
>      return 0;
>  }
>  
> +int xc_domain_cacheflush(xc_interface *xch, uint32_t domid,
> +                         xen_pfn_t start_pfn, xen_pfn_t nr_pfns)
> +{
> +    DECLARE_DOMCTL;
> +    domctl.cmd = XEN_DOMCTL_cacheflush;
> +    domctl.domain = (domid_t)domid;
> +    domctl.u.cacheflush.start_pfn = start_pfn;
> +    domctl.u.cacheflush.end_pfn = start_pfn + nr_pfns;
> +    return do_domctl(xch, &domctl);
> +}

I'm confused - both in the overview mail and in domctl.h below
you state the range to now be inclusive, yet neither here nor
in the hypervisor changes this seems to actually be the case
(unless the earlier "rename ..." patches now did more than just
renaming - I didn't look at them).

> --- a/tools/libxc/xenctrl.h
> +++ b/tools/libxc/xenctrl.h
> @@ -454,7 +454,6 @@ int xc_domain_create(xc_interface *xch,
>                       uint32_t flags,
>                       uint32_t *pdomid);
>  
> -
>  /* Functions to produce a dump of a given domain
>   *  xc_domain_dumpcore - produces a dump to a specified file
>   *  xc_domain_dumpcore_via_callback - produces a dump, using a specified

Stray leftover change?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel