Re: [Xen-devel] function snprintf() in xen_save_domain.c for debugged

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Feb 04, Adel Amani wrote:

>     si.flags = atoi(argv[5]);

> lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL;
> lflags = XTL_STDIOSTREAM_SHOW_PID | XTL_STDIOSTREAM_HIDE_PROGRESS;
> l = (xentoollog_logger *)xtl_createlogger_stdiostream(stderr, lvl, lflags);
> si.xch = xc_interface_open(l,0,0);

Please check what XCFLAGS_DEBUG actually means, and if that condition
can ever be true without modifying also xend related code.

I guess in your exploration of how migration internally actually works
it would be easier for you to just write 'lvl = XTL_DEBUG;' and be done
with it.

Other than that, the changes you made appear to be correct.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel