Re: [Xen-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

["Michael S. Tsirkin" <mst@xxxxxxxxxx>]

On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote:
> Grmbll my fat fingers hit the send shortcut too soon by accident ..
> let's try again ..
> 
> Hi Michael,
> 
> A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 
> breaks pci-passthrough on Xen.
> 
> commit 9e047b982452c633882b486682966c1d97097015
> Author: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Date:   Mon Oct 14 18:01:20 2013 +0300
> 
>     piix4: add acpi pci hotplug support
> 
>     Add support for acpi pci hotplug using the
>     new infrastructure.
>     PIIX4 legacy interface is maintained as is for
>     machine types 1.7 and older.
> 
>     Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> 
> 
> The error is not very verbose :
> 
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error 
> message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error 
> message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error 
> message from QMP server: Device initialization failed.
> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error 
> message from QMP server: Device initialization failed.
> 
> So it seems there is an issue with preserving the legacy interface.


Which machine type is broken?
What's the command line used?
What's the value of has_acpi_build in hw/i386/pc_piix.c?
What happens if you add
-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
?

> --
> Sander
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel