Re: [Xen-devel] [PATCH] tools/gdbsx: define format strings for aarch64

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sun, 2014-02-02 at 09:19 +0100, Olaf Hering wrote:
> gx_main.c: In function '_do_qRcmd_req':
> gx_main.c:119:13: error: format '%llx' expects argument of type 'long long 
> unsigned int', but argument 3 has type 'uint64_t' [-Werror=format=]
>              sprintf(buf1, "pgd3val set to: "XGF64"\n", pgd3val);
>              ^
> gx_main.c:121:13: error: format '%llx' expects argument of type 'long long 
> unsigned int', but argument 3 has type 'uint64_t' [-Werror=format=]
>              sprintf(buf1, "Invalid  pgd3val "XGF64"\n", pgd3val);
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

I suppose there is no harm in this, but is there any chance that gdbsx
would actually work on arm64 without significant actual work going into
it?

Also, you forgot to CC the gdbsx maintainer.

(why doesn't this code use stdint.h?)

> ---
>  tools/debugger/gdbsx/xg/xg_public.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/debugger/gdbsx/xg/xg_public.h 
> b/tools/debugger/gdbsx/xg/xg_public.h
> index 6236d08..046e21b 100644
> --- a/tools/debugger/gdbsx/xg/xg_public.h
> +++ b/tools/debugger/gdbsx/xg/xg_public.h
> @@ -23,7 +23,7 @@
>  #define XGTRC1(...)  \
>             do {(xgtrc_on==2) ? (xgtrc(__FUNCTION__,__VA_ARGS__)):0;} while 
> (0)
>  
> -#if defined(__x86_64__)
> +#if defined(__x86_64__) || defined(__aarch64__)
>      #define  XGFM64  "%lx"
>      #define  XGF64   "%016lx"
>  #else



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel