Re: [Xen-devel] [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-01-30 at 14:55 +0000, Joby Poriyath wrote:
> On Thu, Jan 30, 2014 at 02:06:58PM +0000, Ian Campbell wrote:
> > > > Perhaps ["\']([^"\']*)["\'] is more accurate (i.e. disallow quotes in
> > > > the name itself, although you might have to split into handling " and '
> > > > separately to be more correct
> > 
> > Any thoughts on this?
> 
> The two regexes seems to be equivalent.

OK

> Should I send an updated patch along with an example of RHEL 7 grub.cfg
> or is this patch acceptable as it is?

Yes, please send an updated patch with the example added and CC George +
make a case for a release exception.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel