Re: [Xen-devel] [PATCH] xl: update check-xl-disk-parse to handle backend_domname

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-28 at 19:12 +0100, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Thanks.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I think it doesn't need a freeze exception, so I'll commit it when I
next go through my queue.

As an aside if anyone is looking for a project wiring up this and other
tests into a toplevel "make test" would be awesome. I'm not sure if it
would be complicated by some of the tests needing to run on an active
Xen host (as opposed to a build machine). Perhaps many of the tests
could be made to not rely on running under Xen, or if there was an easy
way to easily create a tarball of the tests which could be deployed and
run?

Once something like that is in place then adding it to the push gate
should be relatively simple, I think. It would also be possible to ask
people to run them before submitting patches etc.

If it didn't require running under Xen then I'd also add it to my
pre-commit test scripts.

Ian.

> ---
>  tools/libxl/check-xl-disk-parse | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/libxl/check-xl-disk-parse b/tools/libxl/check-xl-disk-parse
> index 41fb7af..797277c 100755
> --- a/tools/libxl/check-xl-disk-parse
> +++ b/tools/libxl/check-xl-disk-parse
> @@ -53,6 +53,7 @@ one $e foo
>  expected <<END
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": "/dev/vg/guest-volume",
>      "vdev": "hda",
>      "backend": "unknown",
> @@ -73,6 +74,7 @@ one 0 raw:/dev/vg/guest-volume,hda,w
>  expected <<END
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": "/root/image.iso",
>      "vdev": "hdc",
>      "backend": "unknown",
> @@ -94,6 +96,7 @@ one 0 raw:/root/image.iso,hdc:cdrom,ro
>  expected <<EOF
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": "/dev/vg/guest-volume",
>      "vdev": "xvdb",
>      "backend": "phy",
> @@ -110,6 +113,7 @@ one 0 
> backendtype=phy,vdev=xvdb,access=w,target=/dev/vg/guest-volume
>  expected <<EOF
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": "",
>      "vdev": "hdc",
>      "backend": "unknown",
> @@ -130,6 +134,7 @@ one 0 ,empty,hdc:cdrom,r
>  expected <<EOF
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": null,
>      "vdev": "hdc",
>      "backend": "unknown",
> @@ -147,6 +152,7 @@ one 0 vdev=hdc,access=r,devtype=cdrom
>  expected <<EOF
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": 
> "iqn.2001-05.com.equallogic:0-8a0906-23fe93404-c82797962054a96d-examplehost",
>      "vdev": "xvda",
>      "backend": "unknown",
> @@ -166,6 +172,7 @@ one 0 
> vdev=xvda,access=w,script=block-iscsi,target=iqn.2001-05.com.equallogic:0-
>  expected <<EOF
>  disk: {
>      "backend_domid": 0,
> +    "backend_domname": null,
>      "pdev_path": "app01",
>      "vdev": "hda",
>      "backend": "unknown",
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel