Re: [Xen-devel] [PATCH] minios: Correct HYPERVISOR_physdev_op()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-01-27 at 17:20 +0000, Andrew Cooper wrote:
> On 27/01/14 17:18, Ian Campbell wrote:
> > On Fri, 2014-01-24 at 18:28 +0000, Andrew Cooper wrote:
> >> A physdev_op is a two argument hypercall, taking a command paramter and an
> >> optional pointer to a structure.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >> CC: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> > This hypercall is unused in minios and stubdoms I think? (Trying to
> > gauge how critical the error is).
> 
> Correct.  I suppose it is more of a "nice to fix" than "must fix" at
> this stage, although I was quite surprised that I needed to fix it.

Given that the function is just wrong and that it appears to be unused
in tree I think a simple compile test to confirm is sufficient to take
it into 4.4. Since that succeeded I have acked + applied.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel