[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/hotplug: fix bug on xendomains using xl

Il 24/01/2014 17:16, George Dunlap ha scritto:
On 01/24/2014 02:45 PM, Fabio Fantoni wrote:
Il 21/01/2014 14:56, Ian Campbell ha scritto:
On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
Make rdname function work with xl

Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although I would have preferred a slightly more verbose changelog.

This patch fix this problem:
and perhaps also other problems.

I have done extensive testing with the addition of this patch without encountering errors, can it be added to the 4.4?

Thanks for any reply.

Ian said he was OK with the patch, but that he wished it had a better description.

The one-line description is good; but a better body description would include:

1) A description of what's wrong
2) How this patch fixes the problem


rdname function not support json output of xl commands and this cause problems using xl, for example check if domUs is already running (because restored) on domUs autostart and do create in any case, if domU is already running xl create fails with error instead skip it. This patch add support of json output on rdname function sed solving this problem and probably also problems of other cases. I tried all possible cases that came to mind only after the patch, andI haven't encountered problems but I do not know what other situations have solved in addition to the case described above.

Add something similar to the description can be good?

Thanks for any reply and sorry for my bad english.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.