Re: [Xen-devel] Fix misplaced kfree from xlated_setup_gnttab_pages

[Dave Jones <davej@xxxxxxxxxx>]

On Fri, Jan 24, 2014 at 01:46:55PM -0500, Konrad Rzeszutek Wilk wrote:
 > Actually it should also be freed on the success path, as so:
 > 
 > I can squash it in, if you are OK with that?
 
Looks good to me.

thanks,

        Dave

 > diff --git a/arch/x86/xen/grant-table.c b/arch/x86/xen/grant-table.c
 > index 103c93f..c985835 100644
 > --- a/arch/x86/xen/grant-table.c
 > +++ b/arch/x86/xen/grant-table.c
 > @@ -162,14 +162,15 @@ static int __init xlated_setup_gnttab_pages(void)
 >      rc = arch_gnttab_map_shared(pfns, nr_grant_frames, nr_grant_frames,
 >                                  &xen_auto_xlat_grant_frames.vaddr);
 >  
 > -    kfree(pages);
 >      if (rc) {
 >              pr_warn("%s Couldn't map %ld pfns rc:%d\n", __func__,
 >                      nr_grant_frames, rc);
 >              free_xenballooned_pages(nr_grant_frames, pages);
 > +            kfree(pages);
 >              kfree(pfns);
 >              return rc;
 >      }
 > +    kfree(pages);
 >  
 >      xen_auto_xlat_grant_frames.pfn = pfns;
 >      xen_auto_xlat_grant_frames.count = nr_grant_frames;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel