Re: [Xen-devel] [PATCH 2/4] dbg_rw_guest_mem: Enable debug log output

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

Don Slutz <dslutz@xxxxxxxxxxx> wrote:
>On 01/04/14 16:13, Konrad Rzeszutek Wilk wrote:
>> On Sat, Jan 04, 2014 at 12:52:14PM -0500, Don Slutz wrote:
>>> This also fixes the old debug output to compile and work if DBGP1
>>> and DBGP2 are defined like DBGP3.
>>>
>>> @@ -226,3 +239,11 @@ dbg_rw_mem(dbgva_t addr, dbgbyte_t *buf, int
>len, domid_t domid, int toaddr,
>>>       return len;
>>>   }
>>>   
>>> +/*
>>> + * Local variables:
>>> + * mode: C
>>> + * c-file-style: "BSD"
>>> + * c-basic-offset: 4
>>> + * indent-tabs-mode: nil
>>> + * End:
>>> + */
>> ??
>
>I take that as "Why add this"?

>
>Dealing with many different styles of code, I find it helps to have
>this 
>emacs add.  From CODING_STYLE:

Sure. But then this should be a separate patch. The way both in Xen and Linux 
is to have one logical change per patch.

I would recommend you split this out from this patch.
>
>    Emacs local variables
>    ---------------------
>
>   A comment block containing local variables for emacs is permitted at
>    the end of files.  It should be:
>
>    /*
>      * Local variables:
>      * mode: C
>      * c-file-style: "BSD"
>      * c-basic-offset: 4
>      * indent-tabs-mode: nil
>      * End:
>      */
>
>    -Don Slutz



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel