Re: [Xen-devel] [PATCH RFC 4/4] xen-netfront: Add support for multiple queues

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 16, 2014 at 10:39:45AM +0000, David Vrabel wrote:
> On 16/01/14 10:24, Andrew Bennieston wrote:
> > On 16/01/14 00:27, Wei Liu wrote:
> >> On Wed, Jan 15, 2014 at 04:23:24PM +0000, Andrew J. Bennieston wrote:
> >> 
> >>> +            goto error;
> >>> +        }
> >>> +        snprintf(path, pathsize, "%s/queue-%u",
> >>> +                dev->nodename, queue->number);
> >>> +    }
> >>> +    else
> >>> +        path = (char *)dev->nodename;
> >>
> >> Coding style. Should be surounded by {};
> > 
> > OK.
> 
> Linux style is single line blocks are not surrounded by braces.  You

Not if the other branch contains multiple statements and is surounded by
braces. See Documentation/CodingStyle line 169. ;-)

Wei.

> should have the else on the same line as the preceeding } though.
> 
> i.e.,
> 
> if (...) {
>    one_line()
>    two_line()
>    red_line()
>    blue_line()
> } else
>    a_line()
> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel