Re: [Xen-devel] [PATCH v3 10/16] x86/VPMU: Initialize PMU for PV guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 01/13/2014 09:04 AM, Jan Beulich wrote:
> > > > On 06.01.14 at 20:24, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/hvm/svm/vpmu.c
> > +++ b/xen/arch/x86/hvm/svm/vpmu.c
> > @@ -373,16 +373,21 @@ static int amd_vpmu_initialise(struct vcpu *v)
> >          }
> >       }
> >   
> > -    ctxt = xzalloc_bytes(sizeof(struct amd_vpmu_context) +
> > -                        sizeof(uint64_t) * AMD_MAX_COUNTERS +
> > -                        sizeof(uint64_t) * AMD_MAX_COUNTERS);
> > -    if ( !ctxt )
> > +    if ( is_hvm_domain(v->domain) )
> Here and elsewhere - did you consider whether is_hvm_domain() is
> still the correct thing here now that PVH code is in?
I actually know that this is broken --- I ran a PVH guest a couple of 
days ago and it exploded because of this check.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel