[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/libx: xl uptime doesn't require argument



Ian Jackson writes ("Re: [PATCH] tools/libx: xl uptime doesn't require 
argument"):
> Julien Grall writes ("Re: [PATCH] tools/libx: xl uptime doesn't require 
> argument"):
> > No, the last argument of SWITCH_FOREACH_OPT indicates how many argument
> > is required.
> > 
> > With this simple patch I can do:
> > 42sh> xl uptime
> > Name                                ID Uptime
> > Domain-0                             0 12:25:52
> 
> Oh wait I see the "nb_domains==0" case in print_uptime.  Foolish me
> for expecting xl's logic to have any kind of rationale.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> And added to my backport list.

This applied cleanly to 4.3.

But it didn't apply cleanly to 4.2 and the code there is somewhat
different so I wasn't sure just fixing up the textual changes would be
sufficient.  I would be inclined not to backport it to 4.2 unless
someone thinks this fix is important and would like to prepare a
tested backport.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.