Re: [Xen-devel] [PATCH net-next] xen-netback: stop vif thread spinning if frontend is unresponsive

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of David Miller
> Sent: 07 January 2014 21:30
> To: Paul Durrant
> Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; Wei Liu; Ian Campbell;
> David Vrabel
> Subject: Re: [PATCH net-next] xen-netback: stop vif thread spinning if
> frontend is unresponsive
> 
> From: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Date: Tue, 7 Jan 2014 16:25:29 +0000
> 
> > @@ -477,6 +477,7 @@ static void xenvif_rx_action(struct xenvif *vif)
> >     unsigned long offset;
> >     struct skb_cb_overlay *sco;
> >     int need_to_notify = 0;
> > +   int ring_full = 0;
> 
> Please use bool, false, and true.
> 
> >
> > -   if (!npo.copy_prod)
> > +   if (!npo.copy_prod) {
> > +           if (ring_full)
> > +                   vif->rx_queue_stopped = true;
> >             goto done;
> > +   }
> > +
> > +   vif->rx_queue_stopped = false;
> 
> And then you can code this as:
> 
>       vif->rx_queue_stopped = (!npo.copy_prod && ring_full);
>       if (!npo.copy_prod)
>               goto done;

Sure. I was just following style (of need_to_notify). If you prefer bool then 
I'll use that and also convert need_to_notify.

  Paul

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel