Re: [Xen-devel] [PATCH net-next v3 6/9] xen-netback: Handle guests with too many frags

[Eric Dumazet <eric.dumazet@xxxxxxxxx>]

On Wed, 2014-01-08 at 00:10 +0000, Zoltan Kiss wrote:

>  
> +             if (skb_shinfo(skb)->frag_list) {
> +                     nskb = skb_shinfo(skb)->frag_list;
> +                     xenvif_fill_frags(vif, nskb, INVALID_PENDING_IDX);
> +                     skb->len += nskb->len;
> +                     skb->data_len += nskb->len;
> +                     skb->truesize += nskb->truesize;
> +                     skb_shinfo(skb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
> +                     skb_shinfo(nskb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
> +                     vif->tx_zerocopy_sent += 2;
> +                     nskb = skb;
> +
> +                     skb = skb_copy_expand(skb,
> +                                     0,
> +                                     0,
> +                                     GFP_ATOMIC | __GFP_NOWARN);

skb can be NULL here

> +                     skb_shinfo(skb)->destructor_arg = NULL;
> +             }
>               if (skb_is_nonlinear(skb) && skb_headlen(skb) < PKT_PROT_LEN) {
>                       int target = min_t(int, skb->len, PKT_PROT_LEN);
>                       __pskb_pull_tail(skb, target - skb_headlen(skb));
> @@ -1568,6 +1660,9 @@ static int xenvif_tx_submit(struct xenvif *vif)
>               }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel