Re: [Xen-devel] [PATCH v2] xen/dts: Don't translate invalid address

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-01-06 at 16:36 +0000, Julien Grall wrote:
> ePAR specifies that if the property "ranges" doesn't exist in a bus node:
> 
> "it is assumed that no mapping exists between children of node and the parent
> address space".
> 
> Modify dt_number_of_address to check if the list of ranges are valid. Return
> 0 (ie there is zero range) if the list is not valid.
> 
> This patch has been tested on the Arndale where the bug can occur with the
> '/hdmi' node.
> 
> Reported-by: <tsahee@xxxxxxx>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> This patch is a bug fix for Xen 4.4. Without it, Xen can't boot on the Arndale
> because it's unable to translate a wrong address.

RM hat: Arndale is one of our main platforms today, so not working out
of the box is a pretty serious issue. The risk of course is that we
break things on some other platform. I think we know that none of the
other platforms have this problem, since otherwise Xen wouldn't boot on
them. Given the ePAPR specification trying to translate these addresses
is totally meaningless so it seems unlikely that stopping trying to
translate them would cause an issue. So I think this is OK.

Applied.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel