|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] evtchn/fifo: initialize priority when events are bound
On 16/12/13 13:45, David Vrabel wrote: > On 10/12/13 14:50, Jan Beulich wrote: >>>>> On 10.12.13 at 14:56, David Vrabel <david.vrabel@xxxxxxxxxx> wrote: >>> From: David Vrabel <david.vrabel@xxxxxxxxxx> >>> >>> Event channel ports that are reused or that were not in the initial >>> bucket would have a non-default priority. >>> >>> Add an init evtchn_port_op hook and use this to set the priority when >>> an event channel is bound. >>> >>> Within this new evtchn_fifo_init() call, also check if the event is >>> already on a queue and print a warning, as this event may have its >>> first event delivered on a queue with the wrong VCPU or priority. >>> This guest is expected to prevent this (if it cares) by not unbinding >>> events that are still linked. >>> >> >> Reported-by: Jan Beulich <jbeulich@xxxxxxxx> >> >>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx> >> >> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> > > Keir, if you hadn't noticed, this touches common code and thus needs > your ack. Ping? > I would like to see these fixes go in prior to the first RC as without > patch 2, the FIFO event channels don't really work if irqbalanced is > used (which seems to be a common setup[1]). > > David > > [1] Except my main test box for some reason... David _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |