Re: [Xen-devel] [PATCH V4] xl: create VFB for PV guest when VNC is specified

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jan 06, 2014 at 04:39:30PM +0000, Ian Campbell wrote:
> On Wed, 2013-12-18 at 13:46 +0000, Wei Liu wrote:
> > On Wed, Dec 18, 2013 at 01:12:13PM +0000, Ian Campbell wrote:
> > > On Tue, 2013-12-17 at 22:53 +0000, Wei Liu wrote:
> > > > This replicates a Xend behavior. When you specify 'vnc=1' and there's no
> > > > 'vfb=[]' in a PV guest's config file, xl parses all top level VNC 
> > > > options and
> > > > creates a VFB for you.
> > > > 
> > > > Fixes bug #25.
> > > > http://bugs.xenproject.org/xen/bug/25
> > > > 
> > > > Reported-by: Konrad Wilk <konrad.wilk@xxxxxxxxxx>
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > 
> > > Looks good.
> > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > 
> > > Has this had a discussion about the 4.4 release? It's somewhere between
> > > a bug fix and a new feature, I suppose more of a bug fix.
> > > 
> > 
> > Yes it is a bug fix.
> > 
> > CC'ing George now.
> 
> And now George has gone away and left me holding the can, smart move on
> his part ;-)
> 
> With RM hat on my main concern here is that this smells an awful lot
> like a new feature and not strictly a bug fix (the presence of a bug is
> a bit of a red-herring, it's notionally a wishlist bug even if it isn't
> currently tagged as such).
> 
> On the flip side we have been giving somewhat special dispensation to
> "bugs" of the form "xl does not do $something_xend_did" and treating
> them as something stronger than wishlist (although I'm not sure how much
> stronger). I notice that George has moved all of those under backlog in
> the latest 4.4 dev update though (see [1]), so I'm not sure if he would
> still apply this rule (were I to know what it actually was).
> 

FWIW the wiki page you looked at was updated on Dec 5 while in 
<CAFLBxZZYMU3wJey4tZN9pVrfeTeujLQLBRbiGe-WFevpO2UhvQ@xxxxxxxxxxxxxx>
which was sent later on Dec 13. This bug was the first one in "open"
category. That's why I picked this one in the first place. :-)

That said, I'm not urging to merge this in. This is just my side work
when I was relatively free. I'm fine with any decision you make.

Wei.

> [1] 
> http://wiki.xen.org/wiki/Xen_Roadmap/4.4#Meta-items_.28composed_of_other_items.29

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel