Re: [Xen-devel] [PATCH] enable/disable dom0_11_mapping from command-line and default to enabled

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Sun, 5 Jan 2014, Karim Raslan wrote:
> Signed-off-by: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>

Thanks!
Given that dom0_11_mapping is an int, the patch is OK.
However it might be better to turn dom0_11_mapping into a bool_t and use
boolean_param instead.


>  xen/arch/arm/domain_build.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index faff88e..2831ad0 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -23,6 +23,7 @@ static unsigned int __initdata opt_dom0_max_vcpus;
>  integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>  
>  static int dom0_11_mapping = 1;
> +integer_param("dom0_11_mapping", dom0_11_mapping);
>  
>  #define DOM0_MEM_DEFAULT 0x8000000 /* 128 MiB */
>  static u64 __initdata dom0_mem = DOM0_MEM_DEFAULT;
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel