Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 19/12/13 15:03, Levente Kurusa wrote:
> This is required so that we give up the last reference to the device.
> 
> Signed-off-by: Levente Kurusa <levex@xxxxxxxxx>
> ---
>  drivers/xen/xenbus/xenbus_probe.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c 
> b/drivers/xen/xenbus/xenbus_probe.c
> index 3c0a74b..4abb9ee 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -465,8 +465,10 @@ int xenbus_probe_node(struct xen_bus_type *bus,
>  
>       /* Register with generic device framework. */
>       err = device_register(&xendev->dev);
> -     if (err)
> +     if (err) {
> +             put_device(&xendev->dev);
>               goto fail;
> +     }
>  
>       return 0;
>  fail:

There is a kfree(xendev) here so this introduces a double-free.

David


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel