Re: [Xen-devel] [BUGFIX] [PATCH] kexec/x86: Do map crash kernel area

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 02/01/14 10:48, Andrew Cooper wrote:
> On 02/01/14 10:46, David Vrabel wrote:
>> On 01/01/14 16:51, Don Slutz wrote:
>>> Revert of commit 7113a45451a9f656deeff070e47672043ed83664
>> Since this commit introduced a regression, a revert is the best thing to
>> do here.
>>
>> Acked-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>>
>>> Using kexec commit 027413d822fd57dd39d2d2afab1484bc6b6b84f9
>>>
>>> With "crashkernel=256M@256M" ((XEN) Kdump: 256MB (262144kB) at 0x10000000)
>> I guess Daniel tested a debug build without this crashkernel option.
>> This would place the crash region above the direct mapping region and
>> map_domain_page() would do the right thing.
>>
>>
>>> +    map_pages_to_xen((unsigned long)__va(kexec_crash_area.start),
>>> +                     kexec_crash_area.start >> PAGE_SHIFT,
>>> +                     PFN_UP(kexec_crash_area.size), PAGE_HYPERVISOR);
>>> +
>> This should be made conditional on the location of the crash region --
>> it is wrong to do this for portions of the crash region that are outside
>> the crash region.
> 
> Presume you mean "outside the direct-map region"?

Yes.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel