Re: [Xen-devel] [BUGFIX][PATCH 3/4] hvm_save_one: return correct data.

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 12/16/13 13:33, Andrew Cooper wrote:

Not sure why it took till late 12/21 for me to get this e-mail.

> On 16/12/2013 17:51, Don Slutz wrote:
> > On 12/16/13 03:17, Jan Beulich wrote:
> > > > > > On 15.12.13 at 17:51, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> > > > On 15/12/2013 00:29, Don Slutz wrote:
[snip]
> Your loop condition needs to change be "off < (ctxt.cur -
> sizeof(*desc))" otherwise the "off +=  sizeof(*desc)" can wander beyond
> ctxt.cur in the loop body.  You also need to verify that the
> copy_to_guest doesn't exceed ctxt.cur.
fixed.
> Stylistically, "desc = (void *)ctxt.data + off;" needs to be "desc =
> (void *)(ctxt.data + off);" as the latter is standards compliment C
> while the former is UB which GCC has an extension to deal with sensibly.
fixed.
> Also you have a double space before sizeof in "off +=  sizeof(*desc);"
Fixed.  Version 4 attached.
> ~Andrew
   -Don Slutz

Attachment: 0001-hvm_save_one-return-correct-data.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel