Re: [Xen-devel] [PATCH v7 01/19] xen: add PV/PVH kernel entry point

[Konstantin Belousov <kostikbel@xxxxxxxxx>]

Thank you for doing the split.

On Thu, Dec 19, 2013 at 07:54:38PM +0100, Roger Pau Monne wrote:
> Add the PV/PVH entry point and the low level functions for PVH
> initialization.
> ---
>  sys/amd64/amd64/locore.S     |   53 +++++++++++++++++++++++++++++++
>  sys/amd64/amd64/machdep.c    |   72 
> ++++++++++++++++++++++++++++++++++++++++++
>  sys/amd64/include/asmacros.h |   26 +++++++++++++++
The changes to the three files above all protected by #ifdef XENHVM.
IMO it is more logical to move the code into xen-specific files.
The support would be localized and somewhat postpone morphing the
sys/amd64 into the maze of #ifdefs, which is the sys/i386 already.

Attachment: pgpIb_RjNpmEA.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel