Re: [Xen-devel] [PATCH] tools/libx: xl uptime doesn't require argument

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/19/2013 04:54 PM, Ian Jackson wrote:
> Julien Grall writes ("[PATCH] tools/libx: xl uptime doesn't require 
> argument"):
>> The current behavior is:
>>
>> 42sh> xl uptime
>> 'xl uptime' requires at least 1 argument.
>>
>> Usage: xl [-v] uptime [-s] [Domain]
>>
>> The normal behavior should list uptime for each domain when there is no
>> parameters.
> 
> Maybe I'm confused, but the current code seems not to do that even if
> you change option parsing spec.  Is there part of your patch missing ?

No, the last argument of SWITCH_FOREACH_OPT indicates how many argument
is required.

With this simple patch I can do:
42sh> xl uptime
Name                                ID Uptime
Domain-0                             0 12:25:52

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel