Re: [Xen-devel] [PATCH v6 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-18 at 16:48 +0000, Julien Grall wrote:
> On 12/17/2013 04:27 PM, Julien Grall wrote:
> > @@ -343,12 +353,35 @@ static int create_p2m_entries(struct domain *d,
> >  
> >                      memset(&pte, 0x00, sizeof(pte));
> >                      write_pte(&third[third_table_offset(addr)], pte);
> > +                    count++;
> >                  }
> >                  break;
> >          }
> >  
> >          if ( flush )
> >              flush_tlb_all_local();
> > +
> > +        /* Preempt every 2MiB (mapped) or 32 MiB (unmapped) - arbitrary */
> > +        if ( op == RELINQUISH && count >= 0x2000 )
> > +        {
> > +            if ( hypercall_preempt_check() )
> > +            {
> > +                p2m->next_gfn_to_relinquish = maddr >> PAGE_SHIFT;
> 
> Oops, I made a mistake in this patch.
> 
> It should be addr instead of maddr.
> 
> As it's already in staging, I will send a fix right now.

Yes please!




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel