Re: [Xen-devel] [PATCH v2] VMX: Eliminate cr3 save/loading exiting when UG enabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.12.13 at 13:49, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
> Jan Beulich wrote on 2013-12-18:
>> Furthermore, you submitted v2 with the same description as v1, even
>> though a correction was already suggested. You should incorporate such
>> feedback rather than leaving it to the maintainers. I'll be looking
>> forward to see a v3, hopefully within less than almost 2 months (as
>> was the case for v2 compared to v1, not making the tracking of it easier 
> either).
>> 
> 
> First, you found the regression on 30 Dec. So there is no 2 months until v2. 
> Second, everyone may take vacation or focus on new field and delay a task for 
> long time or never pick it up again. Third, I don't think there are any rule 
> that patch must send out between one or two months.

That's all correct, and not the point of my complaint. All I'm asking
for is that it be made reasonably simple to understand the history
of a patch. Which implies that the longer the gap between two
revisions, the more extended the reminder on what this is about
ought to be.

>> Finally on the earlier thread you suggested that you'd have this go
>> through a full round of testing - nothing in that regard was said here...
>> 
> 
> I said " I will ask our QA to do a full testing against this patch to see 
> whether it introduces any regression" not "we already finished a full round 
> testing and didn't see any regression". And our QA also saw the issue when 
> Xen's automatic testing bot reported the bug. What you want me to said here?

You could have stated exactly that, or perhaps that the new patch
has meanwhile undergone full testing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel