Re: [Xen-devel] [PATCH V3] xl: create VFB for PV guest when VNC is specified

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 17, 2013 at 06:04:58PM +0000, Ian Jackson wrote:
[...]
> As I've said I think evaluating the arguments multiple times is
> better.  After all they have to be lvalues.
> 
> So I would do:
> 
>  #define ARRAY_EXTEND_INIT(array,count,initfn)                       \
>      ({                                                              \
>          typeof((count)) array_extend_old_count = (count);           \
>          (count)++;                                                  \
>          (array) = xrealloc((array), sizeof(*array) * (count));      \
>          (initfn)(&(array)[array_extend_old_count]);                 \
>          &(array)[array_extend_old_count];                           \
>      })
> 

I will take this macro. I don't really have strong opinion on macro
tricks. If you think this is better so be it. The way this macro is
written does affect the core fuctionality of this patch anyway. :-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel