Re: [Xen-devel] [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Dec 13, 2013 at 06:59:06AM +0000, Atsushi Kumagai wrote:
> On 2013/12/10 19:41:54, kexec <kexec-bounces@xxxxxxxxxxxxxxxxxxx> wrote:

[...]

> > Docs are not consistent because man and help displayed from makedumpfile
> > are different. Additionally, even man says nothing how to use this feature
> > on Xen vmcore file. If you use makedumpfile e.g.
> >
> > makedumpfile -Ed 2 /proc/vmcore vmcore
> >
> > it will not work because it uses VMCOREINFO_XEN instead of VMCOREINFO.
> > I discovered that if you would like to use feature from above mentioned
> > patch you must run makedumpfile in following way:
> >
> > makedumpfile -Ed 2 -x vmlinux /proc/vmcore vmcore
> >
> > Then makedumpfile will get info about dom0 directly from vmlinux.
>
> Certainly the documents should be fixed as you said, I'll do it.

Thanks.

> > However, It looks that there is another bug which prevents usage
> > of this feature. It looks it is related to change in P2M tree Linux
> > code. Once P2M levels where changed from 2 to 3. I fixed similar
> > issue in crash tool once.
>
> Thanks for your pointing out, I hope that you will fix that issue
> also in makedumpfile.

Yes, I am going to do that but not now. I am just very busy. Additionally,
I have discovered that this feature code is broken in more places because
it was not maintained more than four years. So, to be honest, it is simply
unusable right now.

> > When are you going to make a new makedumpfile release? I am going
> > to fix this issue before next release but now I am quite busy
> > with other stuff.
>
> I must release the new version(v1.5.5) in the next week at the latest
> because I announced the release date will be the beginning of December
> and there are already many patches for v1.5.5.
> So I would like to slip that fix you mentioned to v1.5.6.

OK.

> > Could you apply patches 1, 2 and 4 from this patch series?
> > It looks that they are not controversial.
>
> Sure, the three patches will be merged into v1.5.5.

Thanks.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel