Re: [Xen-devel] [V7 PATCH 3/7] pvh dom0: implement XENMEM_add_to_physmap_range for x86

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-17 at 15:11 +0000, Jan Beulich wrote:
> >>> On 17.12.13 at 15:40, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Tue, 2013-12-17 at 14:36 +0000, Jan Beulich wrote:
> >> >>> On 17.12.13 at 14:59, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> >> > We could change the code but we could also tighten the interface
> >> > requirements, either by explicit specifying that the range is handled in
> >> > reverse order or by mandating that index/gpfn must not be repeated
> >> > (whether or not we actively try and detect such cases).
> >> 
> >> Specifying that this gets processed backwards would be, well,
> >> backwards. Requiring no duplicates (or else getting undefined
> >> behavior) would be possible. But processing the operation in the
> >> conventional order doesn't seem all that hard.
> > 
> > The reason I thought it would be tricky was finding somewhere to stash
> > the progress over the continuation. Do you have a cunning plan?
> 
> Just like we do in other cases - in the struct that was passed to
> us by the caller (incrementing the handles and decrementing the
> count as needed).

Ah right, forgot we were allowed to fiddle with the handle...




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel