Re: [Xen-devel] [PATCH v5 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.12.13 at 10:26, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2013-12-16 at 17:37 +0000, Julien Grall wrote:
>> +        if ( op == RELINQUISH && count == LPAE_ENTRIES &&
>> +             hypercall_preempt_check() )
>> +        {
> 
> If hypercall_preempt_check returns false the first time it is called
> then you won't ever try again. I think you want
>       (count+1 % LPAE_ENTRIES) == 0
> (the +1 avoids preempting without having done any work yet)

And hence needing proper parenthesization:

        (count+1) % LPAE_ENTRIES == 0

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel