Re: [Xen-devel] [PATCH -next] xen-netback: fix fragments error handling in checksum_setup_ip()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-12-16 at 09:40 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Wei Yongjun [mailto:weiyj.lk@xxxxxxxxx]
> > Sent: 16 December 2013 02:45
> > To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@xxxxxxxxxxxxx
> > Cc: yongjun_wei@xxxxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> > netdev@xxxxxxxxxxxxxxx
> > Subject: [PATCH -next] xen-netback: fix fragments error handling in
> > checksum_setup_ip()
> > 
> > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> > 
> > Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
> > 
> > Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> > setup')
> > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/net/xen-netback/netback.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> > netback/netback.c
> > index 800496b..773b731 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> > struct sk_buff *skb,
> > 
> >     err = -EPROTO;
> > 
> > +   if (fragment)
> > +           goto out;
> > +
> 
> Good grief. This hunk must have got lost from my original patch. My old tree 
> has it there. So...
> 
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel