Re: [Xen-devel] [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2013-12-14 at 00:00 +0000, Julien Grall wrote:
> 
> On 12/13/2013 11:19 PM, Ian Campbell wrote:
> > On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote:
> >> From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>
> >> In this patch, a new type p2m_map_foreign is introduced for pages
> >> that toolstack on PVH dom0 maps from foreign domains that its creating
> >> or supporting during it's run time.
> >>
> >> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> >> Cc: Keir Fraser <keir@xxxxxxx>
> >> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> >>
> >> ---
> >>      Changes in v4:
> >>          - Use the patch #4 from dom0 pvh v6 series. We need it for ARM
> >
> > Is this really the right patch? I'd have thought it would need to
> > include some generic/!x86 bits but:
> 
> This patch introduce p2m_map_foreign type. I think it's safe to push it 
> without the other patches.

Is it really that simple? I suppose there is nothing to create a foreign
mapping on x86 yet so this is harmless?

I'm mostly concerned because the big remaining concern about this stuff
on x86 relates to the reference counting of foreign p2m entries. I'll
defer to the x86 chaps about whether that conversation is directly
related to or impacts this patch or not.

>  Moreover, it will avoid dummy #define 
> p2m_is_foreign in my patch #8.
> 
> >
> >> ---
> >>   xen/arch/x86/mm/p2m-ept.c |    1 +
> >>   xen/arch/x86/mm/p2m-pt.c  |    1 +
> >>   xen/arch/x86/mm/p2m.c     |   28 ++++++++++++++++++++--------
> >>   xen/include/asm-x86/p2m.h |    4 ++++
> >>   4 files changed, 26 insertions(+), 8 deletions(-)
> >
> > Don't you want patch #6 from the PVH series instead?
> 
> I made a mistake in my cover letter. I was talking about patch #6 not 
> #7. I have taken the common code in merge into my patch #8.

OK.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel