Re: [Xen-devel] [RFC PATCH 1/5] xen-pciback: Cleanup up pcistub_put_pci_dev

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.12.13 at 17:09, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> We are using both psdev->dev and dev and both are the same.
> To keep it straight lets just use one - dev.

This should properly describe the patch, which otherwise at the
first glance looks wrong: You're also replacing found_psdev->dev.

> This will also make it easier in the patch:
> "xen/pciback: When reconfiguring an PCIe device, FLR it"
> and "xen/pciback: PCI reset slot or bus" to use it.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Apart from the above,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
>  drivers/xen/xen-pciback/pci_stub.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/xen/xen-pciback/pci_stub.c 
> b/drivers/xen/xen-pciback/pci_stub.c
> index 62fcd48..5300a21 100644
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -272,16 +272,16 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
>        * and want to inhibit the user from fiddling with 'reset'
>        */
>       pci_reset_function(dev);
> -     pci_restore_state(psdev->dev);
> +     pci_restore_state(dev);
>  
>       /* This disables the device. */
> -     xen_pcibk_reset_device(found_psdev->dev);
> +     xen_pcibk_reset_device(dev);
>  
>       /* And cleanup up our emulated fields. */
> -     xen_pcibk_config_free_dyn_fields(found_psdev->dev);
> -     xen_pcibk_config_reset_dev(found_psdev->dev);
> +     xen_pcibk_config_free_dyn_fields(dev);
> +     xen_pcibk_config_reset_dev(dev);
>  
> -     xen_unregister_device_domain_owner(found_psdev->dev);
> +     xen_unregister_device_domain_owner(dev);
>  
>       spin_lock_irqsave(&found_psdev->lock, flags);
>       found_psdev->pdev = NULL;
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel