Re: [Xen-devel] [PATCH] xenconsole: merge pty access check into when it is opened [and 1 more messages]

[Matthew Daley <mattd@xxxxxxxxxxx>]

On Sat, Dec 14, 2013 at 6:01 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH] xenconsole: merge pty access 
> check into when it is opened"):
>> Even as the patch currently stands, the behaviour of the loop has
>> changed. Before, it would eat any error from access(), and only die in
>> the toctou case where open() subsequently failed.
>
> I concur, and v2 of the patch does the same.  This is probably correct
> as Andrew and I discussed.
>
> But the deliberate (or, at least, probably-desirable) behaviour change
> is not reflected in the commit message which only discusses removing
> the race and saving a leak.
>
> Matthew Daley writes ("Re: [PATCH v2] xenconsole: merge pty access check into 
> when it is opened"):
>> Pingy ping?
>
> Sorry for not making this clear sooner, but:
>
> I think this patch is a bugfix and should go into 4.4 so I am happy to
> apply it but the commit message should be improved.  Would you like to
> do that ?

Sure thing. v3 on its way...

- Matthew

>
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel