Re: [Xen-devel] [RFC PATCH 02/10] Add VMware HVM params

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 12/12/13 17:32, Andrew Cooper wrote:
> On 12/12/2013 19:15, Don Slutz wrote:
> > From: Don Slutz <dslutz@xxxxxxxxxxx>
> >
> > Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
> > ---
> >   xen/include/public/hvm/params.h | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
> > index 517a184..c571a1e 100644
> > --- a/xen/include/public/hvm/params.h
> > +++ b/xen/include/public/hvm/params.h
> > @@ -145,6 +145,15 @@
> >   /* SHUTDOWN_* action in case of a triple fault */
> >   #define HVM_PARAM_TRIPLE_FAULT_REASON 31
> >   
> > -#define HVM_NR_PARAMS          32
> > +/* Params for VMware */
> > +#define HVM_PARAM_VMWARE_HW                 32
> > +#define HVM_PARAM_VMPORT_LOGMASK            33
> > +#define HVM_PARAM_VMPORT_STATUS             34
> > +#define HVM_PARAM_VMPORT_BUILD_NUMBER_TIME  35
> > +#define HVM_PARAM_VMPORT_BUILD_NUMBER_VALUE 36
> > +#define HVM_PARAM_VMPORT_RESET_TIME         37
> > +
> > +#define HVM_NR_PARAMS          38
> > +
> >   
> >   #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
> STATUS at the very least sounds like it should be read-only from domains?
It does not need to be.  It is only written to, never read by the code.  So far 
I have only used it as a check (debugging help) while doing manual testing, and 
a simple program that just outputs the hex value was what I used.  At this 
point, it and the code to modify it could be removed.
   -Don
> You might want/need some extra logic in do_hvm_op().
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel