Re: [Xen-devel] [PATCH v2 3/3] libxl: ocaml: use 'for_app_registration' in osevent callbacks

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Rob Hoes writes ("[PATCH v2 3/3] libxl: ocaml: use 'for_app_registration' in 
osevent callbacks"):
> This allows the application to pass a token to libxl in the fd/timeout
> registration callbacks, which it receives back in modification or
> deregistration callbacks.
...
> +     *for_app = caml_callbackN_exn(*func, 4, args);
> +     if (Is_exception_result(*for_app)) {
> +             ret = ERROR_OSEVENT_REG_FAIL;
> +             goto err;
> +     }
> +
> +     caml_register_global_root(for_app);
> +     *for_app_registration_out = for_app;
> +
> +err:
>       CAMLdone;
>       caml_enter_blocking_section();
> -     return 0;
> +     return ret;

Doesn't this have the effect of throwing away the exception
information ?  Perhaps it should be logged somewhere.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel