Re: [Xen-devel] [PATCH 02/13 v2] libxl: check for xc_domain_setmaxmem failure in libxl__build_pre

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2013-12-13 at 18:53 +1300, Matthew Daley wrote:
> Ping?
> 
> On Tue, Dec 3, 2013 at 1:11 AM, Matthew Daley <mattd@xxxxxxxxxxx> wrote:
> > Coverity-ID: 1087115
> > Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
>
Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Regards,
Dario

> > ---
> > v2: Use LIBXL__LOG_ERRNO instead of LOG and return ERROR_FAIL instead of -1
> >
> >  tools/libxl/libxl_dom.c |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > index e95eff8..e696fee 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -224,7 +224,6 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
> >       * whatever that turns out to be.
> >       */
> >      if (libxl_defbool_val(info->numa_placement)) {
> > -
> >          if (!libxl_bitmap_is_full(&info->cpumap)) {
> >              LOG(ERROR, "Can run NUMA placement only if no vcpu "
> >                         "affinity is specified");
> > @@ -238,7 +237,12 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
> >      libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap);
> >      libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus, &info->cpumap);
> >
> > -    xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + 
> > LIBXL_MAXMEM_CONSTANT);
> > +    if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb +
> > +        LIBXL_MAXMEM_CONSTANT) < 0) {
> > +        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "Couldn't set max memory");
> > +        return ERROR_FAIL;
> > +    }
> > +
> >      xs_domid = xs_read(ctx->xsh, XBT_NULL, "/tool/xenstored/domid", NULL);
> >      state->store_domid = xs_domid ? atoi(xs_domid) : 0;
> >      free(xs_domid);
> > --
> > 1.7.10.4
> >
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel