Re: [Xen-devel] [PATCH v2] tools: libxc: flush data cache after loading images into guest memory

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v2] tools: libxc: flush data cache after 
loading images into guest memory"):
> Since this is a tool patch more than and ARM one I should have CCd you,
> sorry.

NP.  I haven't really any comment on whether your cache flushes are
good or not, but two things occur to me:

* Are there other situations where the toolstack (or device model)
  maps domain memory, which also need to be treated ?

* This:

> > +static void minios_privcmd_cache_flush(xc_interface *xch,
> > +                                       const void *ptr, size_t nr)
> > +{
> > +#if defined(__i386__) || defined(__x86_64__)
> > +    /* No need for cache maintenance on x86 */
> > +#else
> > +    PERROR("No cache flush operation defined for architecture");
> > +#endif
> > +}

That appears to just print a warning message to a file no-one will
read.  I think it should crash.

You may save some code by having a single unimplemented_cache_flush
function to put in all these structs.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel