Re: [Xen-devel] [PATCH v3 5/6] xen/arm: Only enable physical IRQs when the guest asks

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/11/2013 12:50 PM, Stefano Stabellini wrote:
> On Tue, 10 Dec 2013, Julien Grall wrote:
> > On 12/10/2013 06:50 PM, Stefano Stabellini wrote:
> > > From: Julien Grall <julien.grall@xxxxxxxxxx>
> > >
> > > Set/Unset IRQ_DISABLED from gic_irq_enable and gic_irq_disable.
> > > Enable IRQs when the guest requests it, not unconditionally at boot time.
> > >
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > >
> > > Changes in v2:
> > > - protect startup and shutdown with gic and desc locks.
> > I think this change can move in patch #4 where you have implemented
> > gic_irq_enable/gic_irq_disable.
> I could move the gic spin_lock there, but the desc spin_lock needs to
> stay in patch #5. Not sure it's worth it.
Oh right, I didn't notice that __setup_irq is called with all the locks 
taken.
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel