Re: [Xen-devel] [RFC PATCH net-next 0/3] unify netfront and netback checksum setup code

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 10 December 2013 18:09
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxx; Wei Liu
> Subject: Re: [Xen-devel] [RFC PATCH net-next 0/3] unify netfront and
> netback checksum setup code
> 
> On Tue, Dec 10, 2013 at 03:39:49PM +0000, Paul Durrant wrote:
> > I'm posting this as RFC to xen-devel before going to netdev to get
> feedback.
> > In patch 1 I've basically taken the latest checksum setup code from
> netback,
> > with all the recent fixes, and pushed it into net/core/dev.c (which seems
> > like the right home for such code). Patch 2 and 3 then just modify netback
> > and netfront to use the new code.
> >
> > Does this look like a reasonable approach? I think it would be good to make
> > the checksum setup code available to all network drivers. There's nothing
> > Xen specific about it.
> >
> >
> 
> I agree it is generally good to consolidate duplicated code so that we
> don't need to maintain two copies of idential code.
> 
> But the acceptance of this series will mainly reuqire acknowledge from
> core driver maintainers. :-)
> 

Indeed. I just wanted a sanity check before I put my head above the parapet :-/

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel