Re: [Xen-devel] [PATCH RFC 3/5] Introduce ts-ovmf-debian-install

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 10, 2013 at 05:36:25PM +0000, Wei Liu wrote:
> On Tue, Dec 10, 2013 at 05:31:12PM +0000, Ian Jackson wrote:
> > Ian Jackson writes ("Re: [PATCH RFC 3/5] Introduce ts-ovmf-debian-install"):
> > > Wei Liu writes ("[PATCH RFC 3/5] Introduce ts-ovmf-debian-install"):
> > > > This is OVMF guest test case. It resembles ts-redhat-install:
> > > > 1. prepare a auto install CD
> > > > 2. install OVMF guest
> > > > 3. test if the guets is up
> > > 
> > > This seems to duplicate an awful lot of the preseed generation from
> > > Osstest::Debian::preseed_create.
> > > 
> > > I'm afraid you'll need to refactor this to remove the duplication.
> > > This might well involve a code-motion-only pre-patch.
> > 
> > Also, how much does this differ from a hypothetical
> > ts-debian-hvm-install ?
> > 
> 
> 1. preseed files are different
> 2. vanilla debian hvm installation won't need to manipulate ISO
> 

Was wrong on the second one. I actually meant vanilla debian manipulates
ISO in slightly different way.

Wei.

> > Perhaps the answer is to have a ts-debian-hvm-install and control the
> > use of ovmf with a runvar.
> > 
> 
> Are those two easy to implement with runvars?
> 
> Wei.
> 
> > Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel