Re: [Xen-devel] [PATCH 4/5] HVM: prevent leaking heap data from hvm_save_one()

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 12/10/2013 03:48 PM, Jan Beulich wrote:
> When one or more of the vCPU-s of a guest are offline, no data may be
> put into the allocated space for them and, due to another bug, such
> uninitialized data may be passed back to the caller.
>
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Release-acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> --- a/xen/common/hvm/save.c
> +++ b/xen/common/hvm/save.c
> @@ -102,7 +102,7 @@ int hvm_save_one(struct domain *d, uint1
>           return -EINVAL;
>   
>       ctxt.size = sz;
> -    ctxt.data = xmalloc_bytes(sz);
> +    ctxt.data = xzalloc_bytes(sz);
>       if ( !ctxt.data )
>           return -ENOMEM;
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel