[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH net] xen-netback: fix abuse of napi budget



On Tue, Dec 10, 2013 at 10:37:36AM +0000, Wei Liu wrote:
> On Tue, Dec 10, 2013 at 10:30:13AM +0000, David Vrabel wrote:
> > On 10/12/13 10:25, Ian Campbell wrote:
> > > On Tue, 2013-12-10 at 10:16 +0000, Paul Durrant wrote:
> > >> netback seemed to be somewhat confused about the napi budget parameter 
> > >> and
> > >> basically ignored it. This patch fixes that, properly limiting the work 
> > >> done
> > >> in each poll.
> > > 
> > > What do you mean "ignored", xenvif_tx_submit seems to be tracking and
> > > testing work_done against the budget.
> > 
> > I have seen this warning in net_rx_action() trigger.
> > 
> >     WARN_ON_ONCE(work > weight);
> > 
> > Which means netback wasn't limiting the work done.
> > 
> 
> But in the original code work_done is returned by xenvif_tx_submit which
> has guard against that situation, right?
> 

And now I think I spot a bug...

  work_done = xenvif_tx_submit(vif, nr_gops);

The second argument should really be "budget". :-(

Wei.

> Wei.
> 
> > David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.