Re: [Xen-devel] [PATCH v2 08/10] xen/arm: Implement xen_rem_foreign_from_p2m

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/09/2013 05:18 PM, Ian Campbell wrote:
> On Mon, 2013-12-09 at 17:08 +0000, Julien Grall wrote:
> > On 12/09/2013 04:31 PM, Ian Campbell wrote:
> > > On Mon, 2013-12-09 at 03:34 +0000, Julien Grall wrote:
[..]

> > > > +        return -EINVAL;
> > > > +    }
> > > > +
> > > > +    guest_physmap_remove_page(d, gpfn, mfn, 0);
> > > > +    put_page(mfn_to_page(mfn));
> > > Some of this could become a common helper with create_p2m_entries and
> > > the relinquish stuff in the previous patch.
> > The best solution is to move put_page in guest_physmap_remove_page. But
> > as we didn't plan to handle refcount for each mapping in Xen 4.4,
> > perhaps we can delay it?
> You can move it and still have it be conditional I think, since g_p_r_p
> can see the type in the pte, can't it?
I plan to move the put_page in create_p2m_entries and check pte type.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel