Re: [Xen-devel] tapdisk in debian 3.11 kernel

[James Harper <james.harper@xxxxxxxxxxxxxxxx>]

> 
> I got it working by initialising ctx_idp to 0. I believe it uses eventfd now
> anyway and the patch is no longer required.
> 

Okay that was stupid. The result was that tapdisk spins at 100% CPU.

The problem is that debian uname is '3.11-0.bpo.2-amd64' and tapdisk detects 
kernel version for eventfd by looking for 'x.y.z', which fails.

This works for me:

diff --git a/drivers/tapdisk-utils.c b/drivers/tapdisk-utils.c
index 4c45c83..7825e13 100644
--- a/drivers/tapdisk-utils.c
+++ b/drivers/tapdisk-utils.c
@@ -256,8 +256,12 @@ int tapdisk_linux_version(void)
                return -errno;

        n = sscanf(uts.release, "%u.%u.%u", &version, &patchlevel, &sublevel);
-       if (n != 3)
-               return -ENOSYS;
+       if (n != 3) {
+               sublevel = 0;
+               n = sscanf(uts.release, "%u.%u", &version, &patchlevel);
+               if (n != 2)
+                       return -ENOSYS;
+       }

        return KERNEL_VERSION(version, patchlevel, sublevel);
 }

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel