Re: [Xen-devel] [PATCH] xen: arm: vtimer fixes for arm64

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/05/2013 12:58 PM, Ian Campbell wrote:
> The code was writing back the register, even for writes and didn't implement
> CNTPCT at all.
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>   xen/arch/arm/vtimer.c |   51 ++++++++++++++++++++++++++++++++++---------------
>   1 file changed, 36 insertions(+), 15 deletions(-)
>
> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
> index f323453..dcda2b2 100644
> --- a/xen/arch/arm/vtimer.c
> +++ b/xen/arch/arm/vtimer.c
> @@ -165,6 +165,27 @@ static void vtimer_cntp_tval(struct cpu_user_regs *regs, 
> uint32_t *r, int read)
>       }
>   }
>
> +static int vtimer_cntpct(struct cpu_user_regs *regs, uint64_t *r, int read)
> +{
> +    struct vcpu *v = current;
> +    uint64_t ticks;
> +    s_time_t now;
> +
> +    if ( read )
> +    {
> +        now = NOW() - v->domain->arch.phys_timer_base.offset;
> +        ticks = ns_to_ticks(now);
> +        *r = ticks;
> +        return 1;
> +    }
> +    else
> +    {
> +        gdprintk(XENLOG_DEBUG, "READ from R/O CNTPCT\n");
s/READ/WRITE/ ?

Except this minor typo:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel