Re: [Xen-devel] [V5 PATCH 6/7] pvh dom0: Add and remove foreign pages

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 05 Dec 2013 12:47:45 +0000
Julien Grall <julien.grall@xxxxxxxxxx> wrote:

> On 12/05/2013 02:05 AM, Mukesh Rathor wrote:
> > In this patch, a new function, xenmem_add_foreign_to_p2m(), is added

..........

> > +#endif
> 
> Here, you can reduce the CONFIG_X86 something like that
> 
> else
> {
>       stuct domain *foreign_dom;
> #ifdef CONFIG_x86
>       p2m_type_t tp;
>       mfn = mfn_x(get_gfn_query(d, xrfp.gpfn, &tp);
>          ASSERT(is_pvh_domain(d));
>          ASSERT(p2m_is_forein(tp));
> #else
>       mfn = gmfn_to_mfn(d, xrfp.gpfn);
> #endif
>          foreign_dom = page_get_owner(mfn_to_page(mfn));
>          ASSERT(d != foreign_dom);
> }
> 
> Until p2m_is_foreign(_t) is correctly setup on ARM,
> remove_from_physmap in ARM will never go to the else part, so it's
> fine.

Again, the change is totally irrelevant to the patch objective, and would
be confusing to someone. Let's add it as a patch with explanation
after this goes in. Meanwhile, everything will remain the same on ARM
after this patch.

thanks
mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel