Re: [Xen-devel] [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > which is hardly nice. This patch fixes this by having each
> > PV driver check for:
> >  - if running in PV, then it is fine to execute (as that is their
> >    native environment).
> >  - if running in HVM, check if user wanted 'xen_emul_unplug=never',
> >    in which case bail out and don't load PV drivers.
> >  - if running in HVM, and if PCI device 5853:0001 (xen_platform_pci)
> >    does not exist, then bail out and not load PV drivers.
> > 
> > P.S.
> > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug'
> > but unfortunatly the xen-blkfront driver is using it, so we
> > cannot do it.
> > 
> > Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx
> > Reported-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > Reported-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> 
> For input:
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Thank you. I need to do some extra changes to the other subsystems but
for the fb/kbd itshould be still throught the same function as this
patch has exposed. I will repost it and include your Ack if you are OK
with that?
> 
> ...
> 
> > +#if defined(CONFIG_XEN_PVHVM)
> > +extern bool xen_has_pv_devices(void);
> > +#else
> > +static inline bool xen_has_pv_devices(void)
> > +{
> > +#if defined(CONFIG_XEN)
> > +   return true;
> > +#else
> > +   return false;
> > +#endif
> 
>       return IS_ENABLED(CONFIG_XEN);
> 
> ?

Oh, awesome!  Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel